It's not a fair comparison. For starters, right now you have P = 1 probability of 100% loss if you don't sign up (barring divine intervention). And then again, every person who invests in cryonics is making it slightly more probable to work for others, as the money goes to research and accumulating experience in doing cryopreservation. National lottery doesn't make it more probable for everyone to win (or at least for future players) if more people play it.
On the contrary, if nobody plays the lottery, nobody will win. The lottery works by randomly redistributing the ticket fees.
I look forward to hearing precisely how you figure I'm going to lose 100% on an investment I'm not making. You're comparing the 100% likely outcome that I do not live forever having spent my money on non-snake oil with the 100% likely outcome that you do not live forever having spent your money on snake oil. The idea that something impossible is going to be more likely because you're spending money on it is just assuming the outcome you want. Unicorns continue not to exist despite every little girl wishing for them. I point out that spending money on unicorn research isn't going to generate them any faster.