Yeah, I never send a PR out without reviewing each commit myself and adding GitH... | Hacker News

Hacker Newsnew | past | comments | ask | show | jobs | submit

		Fishkins 61 days ago \| parent \| context \| favorite \| on: The Theatre of Pull Requests and Code Review Yeah, I never send a PR out without reviewing each commit myself and adding GitHub comments when I think it's relevant. Sometimes a PR is clear enough that I don't feel the need to add comments, though.

tcoff91 60 days ago [–]

I self review but I don’t add comments I just fix the problems that I find. I should add clarifying comments.

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact