Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

If you saw the nonsense some of my teammates try to commit, you would have a completely different view on code review. Just off the top of my head in the past 3 months, they have:

  - Written a 1-line function that returns a literal, but they pointlessly made the function async and added a @cache decorator.
  - Used try/catch to catch ALL exceptions, and then just ignored the exception causing code elsewhere to explode.
  - Used try/catch to catch ALL exceptions, and then log that an authentication error happened. Did the request time out? Well the logs now lie to you and say it was an authentication error.
  - Replace a log statement for a very serious error with a logging.warning() because that makes the error no longer show up on our reports.
If code reviews are that useless to you, that must mean either your team is completely homogeneous in terms of skill level and knowledge, or no one is taking the code reviews seriously.


Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: