I absolutely love magic links. But I also love email, as a technology. I find it so reliable and robust, I genuinely think more things should be built on email.

As with all things, you need to know your audience. If you are making a product for people over 60, probably a simple username/password would work best.