Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Unless I'm misunderstanding the post, it's the author's own code.

(Here's the relevant change, removing those four lines of code: https://github.com/spc476/lua-conmanorg/commit/0ba8d616d1447...)



Oh good spot. I'd misread the repo name as lua-common, I guess my brain "autocorrected" it. The way the article was written, I didn't at all get the impression that it was his code, just that he discovered it and tried hacking it out:

> This bit of code wasn't in the TLS implementation, and as the comment says, it “shouldn't” hurt the TCP path, but hey, it was only needed for local (or Unix) domain sockets to begin with, so let me try removing that bit of code and run a test.

But yeah, if it's his own project, it's far easier to keep track of and watch out for any bug reports that might result from this change.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: