this works for water storage, and some for hydro generation, but for hydro stroage, you really want two large basins with as big of a elevation change as possible.

This is because dams are very expensive, have height limitations, and some inherent risk. Hover dam is only ~200 meters high. The big hydro storage projects have height changes ~400 meters.