> So should we considered the NSA a terrorism-aiding organization
This statement needs the "we" defined to be meaningful.
If it is the U.S., then obviously no, the NSA is an arm of the state. If "we"` is e.g. China, probably no, because words have meanings and the arms of recognized foreign states don't conduct terrorism, they do espionage and they do war. If "we" is a freshman dorm room, then, of course, the NSA is a terrorist organization alongside the student government.
> > So should we considered the NSA a terrorism-aiding organization
> If it is the U.S., then obviously no, the NSA is an arm of the state.
Its perhaps worth noting that “terrorism” originally exclusively denoted action by the State against its own subjects, though it was within a few years expanded to include other activities.
> “terrorism” originally exclusively denoted action by the State against its own subjects
Correct, in the French Revolution, I believe. There are a variety of definitions of terrorism. The common elements seem to be the (a) peacetime use (b) of violence (c) against non-combatants (d) as a political tool. There also seems to be an unspoken requirement that it occurred after the formation of modern states (otherwise almost all of the preceding human history was terrorism and the word gets normalized); the French Revolution is a useful line.
The NSA targets non-combatants (c) in peacetime (a). It does not use violence (b), though it does enable it (⅓b). It does not do so for domestic political aims (to any proven degree); the degree to which it does so abroad depends on where one draws the line between politics and geopolitics. (The CIA, in contrast, engages in all four overseas.)
When an organization that has done terrorism becomes a terrorist organization is another question.
> If it is the U.S., then obviously no, the NSA is an arm of the state.
Some here in the states don't exactly feel like the people running the USG have the people's best interests at heart. Common folk across countries probably have more in common with each other than with the ruling elite.
State-sponsored terrorism is a thing - and has been for a LONG time. And US citizens are targets as well as non-citizens.
There is a community on reddit called "self-aware wolves" that narrowly identifies a much broader phenomenon: there are many elements of modern society which are generally tolerated but not morally permissible. This is a representative instance.
There would need to be some actual violence involved to constitute terrorism. If you spy on some journalist and then us that info to catch him and cut him in pieces while he's still alive, then the dismemberment may be considered terrorism and the spying was aiding that terrorism; if you spy on many people and the end result is just that some officers laugh about their naked photos or deny them jobs or disallow crossing borders, then that's just "ordinary" mass surveillance with no relationship to terrorism.
The NSA does not illegally spy. Congress has given them large authorizations to collect data and they need FISA approval before tapping Americans. 99.9% of the good work that NSA does will never be seen by the public.
edit: the tone is lost via internet; my own opinion on this: yes, it is.